Skip to content

Conversation

@KoditkarVedant
Copy link
Contributor

  • Remove try catch - let the exception bubble up. Now caller to get the NotionApiException and can handle as per their need.
  • Move Api Endpoints in a file for easy maintenance 🎨
    • Remove version /V1 from base url & added as part of api url.
  • Remove dead code ⚰️
  • Restructure files 🚚
  • Refactor rest client ♻️
    • Throws NotionApiException if there is any error while calling API
    • Allow options to configure header
    • Use the SendAsync and HttpRequestMessage to form the request

- Throws NotionApiException if there is any error while calling API
- Allow options to configure header
- Use the SendAsync and HttpRequestMessage to form the request
This help caller to get read the NotionApiException and handle as per their need.
@KoditkarVedant KoditkarVedant merged commit 9d7967a into main May 29, 2021
@KoditkarVedant KoditkarVedant deleted the code-refactor branch May 29, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants